[Button] Fix running formAction when passed #47185
Open
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
type: bug
Netlify deploy previewhttps://deploy-preview-47185--material-ui.netlify.app/ Bundle size report
|
sai6855
commented
Nov 5, 2025
| if (ComponentProp === 'button') { | ||
| buttonProps.type = type === undefined ? 'button' : type; | ||
| // Don't default to 'button' if form attributes are present, to allow form submission | ||
| const hasFormAttributes = !!other.formAction; |
Contributor
Author
There was a problem hiding this comment.
ButtonBase was defaulting to type="button" when no type prop was provided, which prevented form submission and broke formAction functionality. The fix checks for form-related attributes and skips the default type to allow the browser's natural submit behavior (type="submit").
Member
There was a problem hiding this comment.
ButtonBase was defaulting to type="button" when no type prop was provided, which prevented form submission and broke formAction functionality
I think this is worth added as a comment in the code because ButtonBase is a child of the Button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #47181
Before
https://codesandbox.io/p/sandbox/pedantic-germain-nc325h?file=%2Fsrc%2FApp.tsx%3A1%2C1-24%2C1
After
https://stackblitz.com/edit/8rfko5fh?file=src%2FDemo.tsx