[tabs] Fix Arrow key navigation failing when component is rendered in shadow DOM #47178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-47178--material-ui.netlify.app/ Bundle size report
|
sai6855
commented
Nov 4, 2025
|
|
||
| const list = tabListRef.current; | ||
| const currentFocus = ownerDocument(list).activeElement; | ||
| const currentFocus = getActiveElement(ownerDocument(list)); |
Contributor
Author
There was a problem hiding this comment.
Fixed by adding a getActiveElement utility that recursively traverses shadow roots to find the actual focused
element. The issue was that document.activeElement returns the shadow host instead of the focused element inside
shadow DOM, causing keyboard navigation to fail the role="tab" check.
sai6855
changed the title
sai6855
added
type: bug
sai6855
changed the title
Member
|
@sai6855 I would mark this as an "enhancement" instead of a "bug". What do you think? We don't claim to support all components inside Shadow DOM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #47166
Before
https://codesandbox.io/p/sandbox/shadow-dom-test-tabs-component-78x4c8
After
https://stackblitz.com/edit/evlhh47d-8xzn9hbn