-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
[docs][material-ui] Add Number Field component page #47165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewBundle size report
|
| components: Button, IconButton, InputLabel, FormControl, FormLabel, FormHelperText, OutlinedInput | ||
| --- | ||
|
|
||
| # Number Field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mapache-salvaje would love to have your opinion about the structure of this page before moving on to the details of the content. I decided to start this page based on the discussion to showcase Base UI with Material UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you've outlined makes sense! I added one comment about moving the info callout up higher but otherwise the structure looks good to me.
sai6855
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siriwatknp I think it's good to include base-ui NumberField api reference in this section. https://base-ui.com/react/components/number-field#api-reference
| 3. Select the file that starts with `./components/` | ||
| 4. Click the copy icon from the toolbar and paste it into your project. | ||
|
|
||
| :::info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this callout should be part of the introduction to make it more immediately clear what this page is all about.
| components: Button, IconButton, InputLabel, FormControl, FormLabel, FormHelperText, OutlinedInput | ||
| --- | ||
|
|
||
| # Number Field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what you've outlined makes sense! I added one comment about moving the info callout up higher but otherwise the structure looks good to me.
3c1241d to
8762697
Compare
closes #19154
closes #44284
Preview: https://deploy-preview-47165--material-ui.netlify.app/material-ui/react-number-field/
For reviewer
For context and decision, see https://mui-org.slack.com/archives/C061V6JNZ9Q/p1762158626169409