Skip to content

[code-infra] Make error code extraction independent of build #46865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

[code-infra] Make error code extraction independent of build #46865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions .markdownlint-cli2.cjs
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions .markdownlint-cli2.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import { createBaseConfig } from '@mui/internal-code-infra/markdownlint';

export default createBaseConfig();
3 changes: 1 addition & 2 deletions babel.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ const filename = fileURLToPath(import.meta.url);
const dirname = path.dirname(filename);

const errorCodesPath = path.resolve(dirname, './docs/public/static/error-codes.json');
const missingError = process.env.MUI_EXTRACT_ERROR_CODES === 'true' ? 'write' : 'annotate';

/**
* @param {string} relativeToBabelConf
Expand Down Expand Up @@ -53,7 +52,7 @@ export default function getBabelConfig(api) {
[
'@mui/internal-babel-plugin-minify-errors',
{
missingError,
missingError: 'annotate',
Copy link
Member

@Janpot Janpot Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider 'throw' here. I believe the idea behind 'annotate' is that in CI you run a search on built files for these annotations, but we don't do that. We can try this later though.

errorCodesPath,
runtimeModule: '@mui/utils/formatMuiErrorMessage',
},
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"docs:sync-team": "tsx ./docs/scripts/syncTeamMembers.ts && pnpm prettier",
"docs:mdicons:synonyms": "cross-env BABEL_ENV=development babel-node --extensions \".tsx,.ts,.js,.mjs\" ./docs/scripts/updateIconSynonyms && pnpm prettier",
"docs:zipRules": "cd docs && rm mui-vale.zip && zip -r mui-vale.zip mui-vale && cd ../ && pnpm vale sync",
"extract-error-codes": "cross-env MUI_EXTRACT_ERROR_CODES=true lerna run --concurrency 1 build:stable",
"extract-error-codes": "code-infra extract-error-codes --errorCodesPath docs/public/static/error-codes.json --skip @mui/core-downloads-tracker @mui/envinfo @mui/docs @mui/codemod @mui/icons-material",
Copy link
Member

@Janpot Janpot Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, moving this to a global CLI fixes the concurrency problem. I get why this CLI can be superfast now 🤩

"template:screenshot": "cross-env BABEL_ENV=development babel-node --extensions \".tsx,.ts,.js\" ./docs/scripts/generateTemplateScreenshots",
"jsonlint": "code-infra jsonlint",
"eslint": "eslint . --cache --report-unused-disable-directives --ext .js,.ts,.tsx --max-warnings 0",
Expand Down Expand Up @@ -110,9 +110,9 @@
"@babel/plugin-transform-react-constant-elements": "^7.27.1",
"@mui-internal/api-docs-builder": "workspace:^",
"@mui-internal/api-docs-builder-core": "workspace:^",
"@mui/internal-babel-plugin-minify-errors": "^2.0.8-canary.8",
"@mui/internal-bundle-size-checker": "^1.0.9-canary.39",
"@mui/internal-code-infra": "^0.0.3-canary.3",
"@mui/internal-babel-plugin-minify-errors": "^2.0.8-canary.10",
"@mui/internal-code-infra": "^0.0.3-canary.5",
"@mui/internal-docs-utils": "workspace:^",
"@mui/internal-scripts": "workspace:^",
"@mui/internal-test-utils": "workspace:^",
Expand Down
31 changes: 0 additions & 31 deletions packages/markdownlint-rule-mui/duplicate-h1.js
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions packages/markdownlint-rule-mui/git-diff.js
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions packages/markdownlint-rule-mui/straight-quotes.js
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions packages/markdownlint-rule-mui/table-alignment.js
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions packages/markdownlint-rule-mui/terminal-language.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/mui-icons-material/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"build:esm-pkg": "node ./scripts/create-esm-package-json.mjs",
"build:lib": "code-infra build --hasLargeFiles --skipPackageJson --skipBundlePackageJson --skipMainCheck --buildTypes false",
"build:lib:clean": "rimraf lib && pnpm build:lib && shx cp -R build lib",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson --skipMainCheck",
"build:copy-files": "node ../../scripts/copyFiles.mjs",
"build:typings": "node ./scripts/create-typings.mjs",
"release": "pnpm build && pnpm publish",
Expand Down
1 change: 0 additions & 1 deletion packages/mui-joy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
},
"scripts": {
"build": "code-infra build && pnpm build:copy-files",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson",
"build:copy-files": "code-infra copy-files",
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-joy/**/*.test.?(c|m)[jt]s?(x)'",
Expand Down
1 change: 0 additions & 1 deletion packages/mui-lab/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
},
"scripts": {
"build": "code-infra build && pnpm build:copy-files",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson",
"build:copy-files": "code-infra copy-files",
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-lab/**/*.test.?(c|m)[jt]s?(x)'",
Expand Down
1 change: 0 additions & 1 deletion packages/mui-material-nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
},
"scripts": {
"build": "code-infra build && pnpm build:copy-files",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson",
"build:copy-files": "code-infra copy-files",
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-material-nextjs/**/*.test.?(c|m)[jt]s?(x)'",
Expand Down
1 change: 0 additions & 1 deletion packages/mui-material-pigment-css/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
},
"scripts": {
"build": "code-infra build && pnpm build:copy-files",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson",
"build:copy-files": "code-infra copy-files src/styles.css src/styles.css:esm/styles.css",
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-material/**/*.test.?(c|m)[jt]s?(x)'",
Expand Down
1 change: 0 additions & 1 deletion packages/mui-material/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
},
"scripts": {
"build": "code-infra build && pnpm build:copy-files",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson",
"build:copy-files": "code-infra copy-files",
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-material/**/*.test.?(c|m)[jt]s?(x)'",
Expand Down
1 change: 0 additions & 1 deletion packages/mui-private-theming/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
},
"scripts": {
"build": "code-infra build --skipTsc && pnpm build:copy-files",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson",
"build:copy-files": "code-infra copy-files",
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-private-theming/**/*.test.?(c|m)[jt]s?(x)'",
Expand Down
1 change: 0 additions & 1 deletion packages/mui-styled-engine-sc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
},
"scripts": {
"build": "code-infra build --skipTsc && pnpm build:copy-files",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson",
"build:copy-files": "code-infra copy-files",
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-styled-engine-sc/**/*.test.?(c|m)[jt]s?(x)'",
Expand Down
1 change: 0 additions & 1 deletion packages/mui-styled-engine/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
},
"scripts": {
"build": "code-infra build --skipTsc && pnpm build:copy-files",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson",
"build:copy-files": "code-infra copy-files",
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-styled-engine/**/*.test.?(c|m)[jt]s?(x)'",
Expand Down
1 change: 0 additions & 1 deletion packages/mui-stylis-plugin-rtl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
},
"scripts": {
"build": "code-infra build && pnpm build:copy-files",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson",
"build:copy-files": "code-infra copy-files",
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-utils/**/*.test.?(c|m)[jt]s?(x)'",
Expand Down
1 change: 0 additions & 1 deletion packages/mui-system/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
},
"scripts": {
"build": "code-infra build && pnpm build:copy-files",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson",
"build:copy-files": "code-infra copy-files",
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-system/**/*.test.?(c|m)[jt]s?(x)'",
Expand Down
1 change: 0 additions & 1 deletion packages/mui-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"homepage": "https://github.com/mui/material-ui/tree/master/packages/mui-types",
"scripts": {
"build": "code-infra build && pnpm build:copy-files",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson",
"build:copy-files": "code-infra copy-files",
"release": "pnpm build && pnpm publish",
"test": "echo 'No runtime test. Type tests are run with the `typescript` script.'",
Expand Down
1 change: 0 additions & 1 deletion packages/mui-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
},
"scripts": {
"build": "code-infra build && pnpm build:copy-files",
"build:stable": "code-infra build --bundle esm --hasLargeFiles --skipPackageJson --buildTypes false --skipBundlePackageJson",
"build:copy-files": "code-infra copy-files",
"release": "pnpm build && pnpm publish",
"test": "cd ../../ && cross-env NODE_ENV=test mocha 'packages/mui-utils/**/*.test.?(c|m)[jt]s?(x)'",
Expand Down
Loading
Loading