[examples] Add material-ui-react-router-ts example
#46406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
changed the title
material-ui-react-router-ts example
Netlify deploy previewhttps://deploy-preview-46406--material-ui.netlify.app/ Bundle size report
|
Janpot
reviewed
Jun 23, 2025
examples/material-ui-react-router-ts/scripts/unpatch-emotion-packages.js
Outdated
Show resolved
Hide resolved
Janpot
reviewed
Jun 23, 2025
Janpot
reviewed
Jun 23, 2025
Janpot
reviewed
Jun 23, 2025
Janpot
reviewed
Jun 23, 2025
| optimizeDeps: { | ||
| include: ['@emotion/*', '@mui/*'], | ||
| }, | ||
| noExternal: ['@emotion/*', '@mui/*'], |
There was a problem hiding this comment.
😕 This will require the user to add every library that uses emotion in this list?
Janpot
approved these changes
Jun 23, 2025
|
Alright, let's keep an eye on remix-run/react-router#13871 to remove the |
|
Hi, I've been working on solutions regarding the Emotion library and the server side using streaming, and I've arrived here. I saw the solution you implemented, and it works well, but there's just one detail: you're collecting all the chunks and not sending anything to the client until everything is loaded, which makes streaming useless (and therefore the Await and Suspense APIs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #45878, closes #45873
This PR adds example for Material UI + React Router + Vite