[docs] Fix joy templates error #45715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
docs
Netlify deploy previewhttps://deploy-preview-45715--material-ui.netlify.app/ Bundle size report |
siriwatknp
force-pushed
the
docs/joy-template-clash2
branch
from
355ff90 to
53cbcab
Compare
|
@DiegoAndai I think the |
siriwatknp
changed the title
siriwatknp
commented
Mar 27, 2025
| @@ -50,7 +50,7 @@ function NProgressBar(props) { | |||
| height: 2, | |||
| zIndex: (theme.vars || theme).zIndex.tooltip, | |||
| backgroundColor: (theme.vars || theme).palette.primary[200], | |||
| ...theme.applyDarkStyles({ | |||
There was a problem hiding this comment.
@DiegoAndai The root cause of the template error comes from this component.
The NProgressBar is used in all of the joy templates. It try to access theme.applyDarkStyles but the branding theme was removed from the global _app.js so the error appear.
|
Can we split it in two? 😅 |
siriwatknp
force-pushed
the
docs/joy-template-clash2
branch
from
53cbcab to
ea70379
Compare
aarongarciah
previously approved these changes
Mar 27, 2025
aarongarciah
approved these changes
Mar 27, 2025
DiegoAndai
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45707
Currently, all joy templates throw error.
Root cause
The
NProgressBaris used in all of the joy templates. It try to accesstheme.applyDarkStylesbut the branding theme was removed from the global_app.jsso the error appear.Fixed by replacing
applyDarkStyles(was internal for docs) with officialapplyStylesthat comes with the default theme.I took an extra step to replace all occurrences of(split to another PR)applyDarkStylesbecause it's no longer needed.Next step:
applyDarkStylesfrom the core docs