[core] Fix missing CSSProperties/MixinOptions types #45706
Conversation
| @@ -27,28 +28,6 @@ export interface FontStyle { | |||
| htmlFontSize: number; | |||
| } | |||
|
|
|||
| export type NormalCssProperties = CSS.Properties<number | string>; | |||
There was a problem hiding this comment.
@mui/core Am I right in thinking this shouldn't be duplicated?
There was a problem hiding this comment.
Seems to me that it shouldn't be duplicated. I don't have the context as to why it is duplicated in the first place.
@mnajdova do you know?
For reference, the duplication is here: https://github.com/mui/material-ui/blob/51663eba0e020daa6b494c31391560f0dd107489/packages/mui-material/src/styles/createMixins.d.ts
There was a problem hiding this comment.
Tl;dr yes, it should be safe for these to be removed
From what I remember these were initially copied from @mui/styles to make the JSS <-> Emotion interoperability work. They may have been accidently copied in two locations, so it's safe to be removed from here. Eventually we could likely drop these, especially now that the @mui/styles package is deprecated.
Netlify deploy previewhttps://deploy-preview-45706--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the missing CSSProperties type issue and updates import statements to use relative paths for unstable_useId.
- Updated unstable_useId import in IconButton from '@mui/material/utils' to '../utils'.
- Updated unstable_useId import in Button from '@mui/material/utils' to '../utils'.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/mui-material/src/IconButton/IconButton.js | Changed unstable_useId import to a relative path. |
| packages/mui-material/src/Button/Button.js | Changed unstable_useId import to a relative path. |
Janpot
changed the title
Fixes #45703
Fixes #45713
Also noticed several imports that should be relative.
I'm sure there will be others reported the coming days