[styles] Remove code & docs #45633
[styles] Remove code & docs #45633
Conversation
mnajdova
added
the
package: styles
Netlify deploy previewhttps://deploy-preview-45633--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
| @@ -511,6 +511,11 @@ https://v4.material-ui.com/* https://v4.mui.com/:splat 301! | |||
| /material-ui/experimental-api/css-theme-variables/usage/ /material-ui/customization/css-theme-variables/usage/ 301 | |||
| /material-ui/experimental-api/css-theme-variables/customization/ /material-ui/customization/css-theme-variables/configuration/ 301 | |||
| /base-ui/ https://base-ui.com/ 301 | |||
| #2025 | |||
| # TODO v7 change mui.com to v6.mui.com when domains are switched | |||
There was a problem hiding this comment.
@DiegoAndai do we have some pattern for comments to search for before the stable release?
There was a problem hiding this comment.
I'll search for "todo v7" case insensitive. But honestly, at this point, we shouldn't do any further code changes so we can have a safe stable release
github-actions
bot
added
the
PR: out-of-date
I can do after merging 👌 I would use the message: "Deprecated in favor of @mui/system, check the migration instruction in https://mui.com/material-ui/migration/migrating-from-jss/". cc @aarongarciah @DiegoAndai in case you have an opinion on the deprecation message :) |
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
|
It's a bit confusing saying "in favor of @mui/system" when the migration guide doesn't mention - Deprecated in favor of @mui/system, check the migration instruction in https://mui.com/material-ui/migration/migrating-from-jss/
+ Deprecated in favor of @mui/system, check the migration guide in https://mui.com/material-ui/migration/migrating-from-jss/ |
Yeah fair enough. My thought was that the underlaying engine is @mui/system, as historically, @mui/styles utils were exported from @material-ui/core/styles - it was long time tough :D I'll use your proposed deprecation message, but also wait for @DiegoAndai's response before deprecating in case he has an opinion on it. I will proceed with merging the PR, it's not related to it. |
|
Agree with deprecating. Regarding the message, what about:
No need to go into further detail, is just a nudge to migrate and to visit the guide. |
This PR removes the @mui/styles code from the master branch as well as the docs for it, and will redirect to the v6.mui.com docs (after this docs will be published, for now it redirects to mui.com/* pages).