Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Ensure translations.json is present in all @mui/docs package builds #45626

Merged
merged 4 commits into from
Mar 21, 2025

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Mar 19, 2025

Fixes: https://mui-org.slack.com/archives/C042YB5RB3N/p1742407588778789

Related question: do we need the node build, which does not look like it works..? 🤔 🤷
Screenshot 2025-03-19 at 23 01 28

@LukasTy LukasTy added bug 🐛 Something doesn't work scope: code-infra Specific to the core-infra product labels Mar 19, 2025
@LukasTy LukasTy requested a review from a team March 19, 2025 21:02
@LukasTy LukasTy self-assigned this Mar 19, 2025
@mui-bot
Copy link

mui-bot commented Mar 19, 2025

Netlify deploy preview

https://deploy-preview-45626--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6d9a473

@Janpot
Copy link
Member

Janpot commented Mar 20, 2025

do we need the node build

Yes, but that's under the root now. We do need to add esm and modern

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try like this for now

@LukasTy LukasTy merged commit fedac0f into mui:master Mar 21, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants