-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Support nested theme when upper theme is CSS vars theme #45604
Conversation
Netlify deploy previewhttps://deploy-preview-45604--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Confirmed that it works with MUI X repo in combination with #45386 |
I think there may be a breaking change with this. Previously if you passed an empty object to the theme provider ( Now with this change, the theme looks like this:
|
I did experience a breaking change due to this release indeed (bisected to narrow it down to 5.17.0). In my case, setting my theme |
Cherry pick from #45545 and #45368
Need this PR to release on v5 because MUI X docs depends on this version. To unblock #45386 so that the docs (both core and x) can migrate to CSS variables to fix the dark mode flicker issue.