[lab] Remove @mui/base dependency #45602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve-base-dependency
mnajdova
changed the title
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Netlify deploy previewhttps://deploy-preview-45602--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mnajdova
commented
Mar 20, 2025
| @@ -1,5 +1,5 @@ | |||
| 'use client'; | |||
| import { unstable_composeClasses as composeClasses } from '@mui/base'; | |||
| import composeClasses from '@mui/utils/composeClasses'; | |||
There was a problem hiding this comment.
Using the same import as in @mui/material.
mnajdova
commented
Mar 20, 2025
| @@ -1 +1 @@ | |||
| export { useAutocomplete as default } from '@mui/base'; | |||
| export { default } from '@mui/material/useAutocomplete'; | |||
There was a problem hiding this comment.
The hook was already copied in @mui/material when we were removing the @mui/base dependency from there. Here, we are just changing the location of where we re-export.
aarongarciah
changed the title
|
@mnajdova can you add a short PR description? |
Yep, done 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy @mui/base dependency in @mui/lab. This was missed when we were removing the @mui/base from the other @mui/* packages. The changes done replicate what was done in the @mui/material package.
We can now safely remove the packages/mui-base code and leave it only in the v6.x branches (we stopped releasing @mui/base from the main branch some time ago).