[code-infra] Update peer dependency of @mui/utils in @mui/docs
#45561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45561--material-ui.netlify.app/ Bundle size report |
DiegoAndai
reviewed
Mar 12, 2025
There was a problem hiding this comment.
@Janpot X uses Material UI v5 in their docs. Wouldn't this force them to update?
Aren't we updating them in mui/mui-x#16771? |
|
mui/mui-x#16771 goal is to test the integration, I'm not sure if the X team is ready to upgrade their docs, they haven't done it for v6 yet. |
|
We can still update this dependency, to avoid esm-cjs interop errors. |
|
You're right, this would release in the v7 major, so it would only affect X if they upgrade to v7. My bad. |
DiegoAndai
approved these changes
Mar 13, 2025
LukasTy
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to bring this internal package to X/Toolpad docs