[code-infra] Convert a few docs modules to ts #45548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: out-of-date
Netlify deploy previewhttps://deploy-preview-45548--material-ui.netlify.app/ Bundle size report |
github-actions
bot
removed
the
PR: out-of-date
1 task
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
DiegoAndai
reviewed
Mar 12, 2025
There was a problem hiding this comment.
Running the types check with this PR's build on mui/mui-x#16771 returns no errors ✅ 🎉
Just a couple of questions
DiegoAndai
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve a few type errors in mui/mui-x#16771
I initially thought I could just convert these two files to typescript, but the rabbit hole runs deeper. Eventually I stopped converting things to ts and just added a few declaration files