-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Update minimum TypeScript support to 4.9 #45535
Conversation
@@ -14,6 +14,28 @@ In the `package.json` file, change the package version from `latest` to `next`. | |||
Using `next` ensures your project always uses the latest v7 pre-releases. | |||
Alternatively, you can also target and fix it to a specific version, for example, `7.0.0-alpha.0`. | |||
|
|||
## Supported browsers and versions | |||
|
|||
### Minimum TypeScript version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure and content is similar to v6 upgrade guide.
Netlify deploy preview
Bundle size report |
### Minimum React version | ||
|
||
The minimum supported version of React is v17.0.0 (the same as v5 and v6). | ||
Use the snippet below to update your project (replace the `<version>` with the one you want): | ||
|
||
<codeblock storageKey="package-manager"> | ||
|
||
```bash npm | ||
npm install react@<version> react-dom@<version> | ||
``` | ||
|
||
```bash pnpm | ||
pnpm add react@<version> react-dom@<version> | ||
``` | ||
|
||
```bash yarn | ||
yarn add react@<version> react-dom@<version> | ||
``` | ||
|
||
</codeblock> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's the same as v6, I think we can remove this section and keep only the @types/react
one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think that this section is useful. If I am upgrading to v7, I want to know this even though the minimum version is the same.
So I simplified this section instead.
@@ -14,6 +14,47 @@ In the `package.json` file, change the package version from `latest` to `next`. | |||
Using `next` ensures your project always uses the latest v7 pre-releases. | |||
Alternatively, you can also target and fix it to a specific version, for example, `7.0.0-alpha.0`. | |||
|
|||
## Supported browsers and versions | |||
|
|||
### Minimum React version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in #45762, it didn't change.
I have updated the support version page in #45761. |
For v7, align with DefinitelyTyped support window (2 years).
Side benefit of this is to align with the ongoing PR that mention about
satisfies
usage (added in TypeScript 4.9).