Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Radio] Fix inputProps not forwarded #45471

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 3, 2025

closes #45447

Root cause

The slotProps.input is explicitly passed to SwitchBase which always override inputProps.

Fix

Did the same as the Checkbox by fallback the slotProps.input to inputProps.

@siriwatknp siriwatknp added component: radio This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material regression A bug, but worse needs cherry-pick The PR should be cherry-picked to master after merge labels Mar 3, 2025
@mui-bot
Copy link

mui-bot commented Mar 3, 2025

Netlify deploy preview

https://deploy-preview-45471--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 88fd164

@siriwatknp siriwatknp merged commit ebde45f into mui:master Mar 4, 2025
24 checks passed
Copy link

github-actions bot commented Mar 4, 2025

Cherry-pick PRs will be created targeting branches: v6.x

github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: radio This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material regression A bug, but worse v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Radio]: inputProps no longer being applied after introduction of slotProps
3 participants