-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mui-material][Select] Add native-like behavior for select #43871
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
One note is that it does not support mobile devices (which obviously do not have ctrl key) currently. |
* Only applicable when `multiple` is `true` and `native` is `false`. | ||
* @default false | ||
*/ | ||
nativeLike: PropTypes.bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we plan to land this feature we need to come up with a better name for the prop, is too close to the native
prop, and works when the native
prop is false. btw @atomiks do we have this feature planned for the Base UI select?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multi-select is planned for later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atomiks how much later? Asking so we can plan the Select refactor accordingly.
As for this feature, we should only implement it if we're sure that Base UI will eventually implement it. Otherwise, we would support it, only for it to change in the upcoming major version which is built on top of Base UI.
implements #43813 .