Skip to content

Conversation

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 7, 2024

Problem

https://github.com/mui/material-ui/blob/master/examples/material-ui-via-cdn/README.md preview is broken.

SCR-20240908-cjjy

Solution

See https://raw.githack.com/faq#diff-between-rawgithack-and-cdn for why this fixes the problem. Since it's only for demo purposes, we don't care about having our demo production ready.

Requests to CDN are routed through CloudFlare's content delivery network, and are cached for an year the first time they're loaded. This results in the best performance and reduces load on raw.githack.com and on underlying service, but it means that reloading won't fetch new changes

Context

It's another follow-up on #42172. The problem got more visible with v6.x release. I noticed this trying some of the examples that we have (since it's a critical part of the user journey, wanted to experience it as a new user).

Since it was quick to fix, I skipped the opening an issue step and went to PR (It will be better to only open issues in the future, but they tend to be not solved, e.g. #42423 so this should be more effective, until we figure a way to make it work).

@oliviertassinari oliviertassinari added type: bug It doesn't behave as expected. type: regression A bug, but worse, it used to behave as expected. examples Relating to /examples. labels Sep 7, 2024
@mui-bot
Copy link

mui-bot commented Sep 7, 2024

Netlify deploy preview

https://deploy-preview-43641--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4c19018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples Relating to /examples. type: regression A bug, but worse, it used to behave as expected. v6.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants