Skip to content

[docs] Rename jsx-runtime in window object #43639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[docs] Rename jsx-runtime in window object #43639

wants to merge 1 commit into from

Conversation

@Vxee
Copy link
Contributor

@Vxee Vxee commented Sep 7, 2024 •
edited
Loading

@Vxee Vxee mentioned this pull request Sep 7, 2024
Merged
1 task
@mui-bot
Copy link

mui-bot commented Sep 7, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43639--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 78b9c56

@ZeeshanTamboli ZeeshanTamboli changed the title [docs]: rename jsx-runtime in window [docs] Rename jsx-runtime in window object Sep 7, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [docs] Rename jsx-runtime in window object [docs] Rename jsx-runtime in window object Sep 7, 2024
@ZeeshanTamboli ZeeshanTamboli added the scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). label Sep 7, 2024
@Vxee
Copy link
Contributor Author

Vxee commented Sep 11, 2024

@alexfauquette Please help to merge it when you are available, thanks.

@alexfauquette
Copy link
Member

That's a breaking change. Even if it's docs, I'm not in favor of adding a breaking change for the only purpose of renaming stuff

@Vxee
Copy link
Contributor Author

Vxee commented Sep 18, 2024

@alexfauquette I know your concern. This function is created by me. We haven't mentioned this in docs site. So I think it is low impact to rename. I rename it because I use Vite to build the js chunk, I specify the name as jsx, but finally it uses jsxRuntime. So I want to change it and make it easier for developers to integrate.
Now my solution is to modify the file after finishing the build.

@Vxee
Copy link
Contributor Author

Vxee commented Sep 26, 2024

@alexfauquette @siriwatknp Can you take a look? Thanks.

@Vxee
Copy link
Contributor Author

Vxee commented Oct 10, 2024

Don't need to rename it, can control in our build script.

@Vxee Vxee closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees

No one assigned

Labels

scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Vxee @mui-bot @alexfauquette @ZeeshanTamboli