[material-ui][theme] Fix wrong cssVariables TypeScript type in Theme
#43608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Nikl <tomasnikl.cz@gmail.com>
ZeeshanTamboli
changed the title
cssVariables type in Theme interface
ZeeshanTamboli
added
type: bug
ZeeshanTamboli
changed the title
cssVariables type in Theme interfacecssVariables TypeScript type in Theme interface
Netlify deploy previewhttps://deploy-preview-43608--material-ui.netlify.app/ Bundle size report |
Signed-off-by: Tomas Nikl <tomasnikl.cz@gmail.com>
…into fix-theme
ZeeshanTamboli
changed the title
cssVariables TypeScript type in Theme interfacecssVariables TypeScript type in Theme
There was a problem hiding this comment.
Before anything else, I'm not sure if the literal type was intentionally added in #43115 or if it was a mistake. cssVariables is false when there's a theme without CSS variables. However, it seems like a bug based on the CodeSandbox you shared in the issue.
If we switch to using boolean, the cssVariables isn't just boolean; it can have other types too, as shown here and in the docs.
I'll let @siriwatknp review this PR.
|
It's intentional, the Note that the input can be true but at the end it will be set as an object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #43607