[material] Fix wrong import to type #43584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43584--material-ui.netlify.app/ Bundle size report |
mnajdova
commented
Sep 3, 2024
| @@ -1,4 +1,4 @@ | |||
| import { CSSInterpolation } from '@mui/styled-engine'; | |||
| import { CSSInterpolation } from '@mui/system'; | |||
There was a problem hiding this comment.
Material UI should never import directly from @mui/styled-engine, all imports should go through @mui/system (then this package is configured to get the right type from either @mui/styled-engine or @mui/styled-engine-sc depending on which styling engine is used under the hood).
There was a problem hiding this comment.
Maybe we should add an eslint rule to enforce this constraint?
There was a problem hiding this comment.
Good idea, I will look into it.
DiegoAndai
approved these changes
Sep 3, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43575