Skip to content

Conversation

@zanivan
Copy link
Collaborator

@zanivan zanivan commented Aug 29, 2024

Fixes item 24 from #41469

Based on #43369 from @Andarist, this PR fixes the shadows in the custom theme of the templates and adds the 23 remaining shadow tokens from the default theme.

@zanivan zanivan added type: bug It doesn't behave as expected. docs Improvements or additions to the documentation. package: material-ui design This is about UI or UX design, please involve a designer. labels Aug 29, 2024
@zanivan zanivan self-assigned this Aug 29, 2024
@zanivan zanivan changed the title Add other 23 shadows from default theme [docs][material-ui] Fix template shadow tokens Aug 29, 2024
@zannager zannager requested a review from DiegoAndai August 29, 2024 14:05
@DiegoAndai
Copy link
Member

Hey @zanivan! I think there's no need to copy the default shadows manually. Here's an example with a simplified version of the code: https://stackblitz.com/edit/stackblitz-starters-apzykp?file=src%2FApp.tsx

In themePrimitives.ts, the default theme is named customTheme:


Let's change it to defaultTheme.

@mui-bot
Copy link

mui-bot commented Aug 29, 2024

Netlify deploy preview

https://deploy-preview-43514--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 67a07b0

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we look into sharing the TemplateFrame files as well? (having one source as we do with the themes)

@zanivan
Copy link
Collaborator Author

zanivan commented Aug 30, 2024

Should we look into sharing the TemplateFrame files as well? (having one source as we do with the themes)

This would be very helpful 🙏

@zanivan zanivan merged commit c1e89d9 into master Aug 30, 2024
@zanivan zanivan deleted the fix-templates-shadows branch August 30, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design This is about UI or UX design, please involve a designer. docs Improvements or additions to the documentation. type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants