Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blog] Introducing Toolpad Core #43497

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

[blog] Introducing Toolpad Core #43497

wants to merge 9 commits into from
+110 −53

Conversation

prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Aug 28, 2024 •
edited
Loading

Preview: https://deploy-preview-43497--material-ui.netlify.app/blog/introducing-toolpad-core/

  • Add better quality video
  • Improve image
  • Review content
  • Add social card
  • Recheck the date

@mui-bot
Copy link

mui-bot commented Aug 28, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43497--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3008f0a

@prakhargupta1
Copy link
Member Author

@zanivan For this blog post, I have created an image showcasing Toolpad Core components. The font and the overall design has scope for improvement, do you mind taking a moment to review the Figma? Thanks!

@zanivan
Copy link
Contributor

zanivan commented Aug 28, 2024

Hey @prakhargupta1! I’d love to help. I’ll centralize everything in MUI’s Figma file designated for blog posts :)

@zanivan
Copy link
Contributor

zanivan commented Aug 28, 2024

Here it is. Let me know your thoughts about it

image

@prakhargupta1
Copy link
Member Author

Let me know your thoughts about it.

Thanks! it looks much better. I have commented on the Figma.

@prakhargupta1 prakhargupta1 marked this pull request as ready for review August 29, 2024 13:46
@zannager zannager requested a review from zanivan August 29, 2024 14:06
samuelsycamore
samuelsycamore reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks solid! I left a couple small suggestions along the way. The only thing left that I'd like to see would be a nice strong call to action section at the end to direct readers to get started in the Toolpad Core docs.

docs/pages/blog/introducing-toolpad-core.md Outdated Show resolved Hide resolved
docs/pages/blog/introducing-toolpad-core.md Outdated Show resolved Hide resolved
@prakhargupta1
Copy link
Member Author

prakhargupta1 commented Sep 4, 2024 •
edited
Loading

As discussed in yesterday's meeting. I have replaced 'What's next for Toolpad Studio' section to 'What's next' and only covered Toolpad Core plans.

For the CTA, at the end of the post, we can do either of the two:
1. Embed a poll from Toolpad's X handle where we can ask for a vote among some components users would like to see.
2. Embed this thread.

@prakhargupta1 prakhargupta1 mentioned this pull request Sep 4, 2024
Closed
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 5, 2024
oliviertassinari
oliviertassinari reviewed Sep 10, 2024
View reviewed changes
docs/pages/blog/introducing-toolpad-core.md

At MUI, our vision is to provide a unified UI creation ecosystem for web developers. We try to reflect the diverse ways in which developers build UIs in our product offerings:

- Material UI: Low-level components that developers use to build UIs of varying complexity and size.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more about creating a design system on this one.

Suggested change
- Material UI: Low-level components that developers use to build UIs of varying complexity and size.
- Material UI: …

docs/pages/blog/introducing-toolpad-core.md
Comment on lines +28 to +33
- [layout and navigation](https://mui.com/toolpad/core/react-dashboard-layout/)
- [page container](https://mui.com/toolpad/core/react-page-container/)
- [sign-in and account display](https://mui.com/toolpad/core/react-sign-in-page/)
- [dialogs](https://mui.com/toolpad/core/react-use-dialogs/)
- [notifications](https://mui.com/toolpad/core/react-use-notifications/)
- [persisted state](https://mui.com/toolpad/core/react-persistent-state/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upper case on the first word?

docs/pages/blog/introducing-toolpad-core.md
@@ -0,0 +1,50 @@
---
title: Introducing Toolpad Core
Copy link
Member

@oliviertassinari oliviertassinari Sep 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "Introducing" feel too much for something that is stable? For example, I reframed https://mui.com/blog/introducing-pigment-css/ as a "preview" as it felt more accurate to what it is. It's not generally available, it's a sample of what we envision to build.

@prakhargupta1
Copy link
Member Author

Based on yesterday's discussion, I am moving this PR to draft. We'll revisit and publish it after the upcoming features.

@prakhargupta1 prakhargupta1 marked this pull request as draft September 11, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@samuelsycamore samuelsycamore samuelsycamore left review comments

@zanivan zanivan Awaiting requested review from zanivan

@Janpot Janpot Awaiting requested review from Janpot

@bharatkashyap bharatkashyap Awaiting requested review from bharatkashyap

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blog PR: out-of-date The pull request has merge conflicts and can't be merged Toolpad
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@prakhargupta1 @mui-bot @zanivan @oliviertassinari @samuelsycamore