Skip to content

[code-infra] Remove permissions in publish-canaries.yml #43491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

[code-infra] Remove permissions in publish-canaries.yml #43491

merged 1 commit into from
Aug 30, 2024

Conversation

@oliviertassinari
Copy link
Member

It looks like this GitHub action doesn't need GITHUB_TOKEN with permissions to our GitHub repository APIs. Flagged in https://github.com/mui/material-ui/security/code-scanning/69.

@oliviertassinari oliviertassinari added security Pull requests that address a security vulnerability. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). labels Aug 28, 2024
@mui-bot
Copy link

mui-bot commented Aug 28, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43491--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b3604ef

michaldudak
michaldudak approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it won't complain about contents: read, but maybe not since the repo is public.

@oliviertassinari oliviertassinari merged commit eea5079 into mui:master Aug 30, 2024
@oliviertassinari oliviertassinari deleted the reset-permissions-cannary branch August 30, 2024 14:55
@Msolmaz4 Msolmaz4 mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 25, 2024
Open
Open
Open
@prathik2401 prathik2401 mentioned this pull request Sep 26, 2024
Merged
@neelaranjith575 neelaranjith575 mentioned this pull request Sep 26, 2024
Closed
This was referenced Oct 3, 2024
Open
Open
This was referenced Oct 3, 2024
Closed
Closed
@Msolmaz4 Msolmaz4 mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees

No one assigned

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). security Pull requests that address a security vulnerability.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oliviertassinari @mui-bot @michaldudak