- 
          
- 
        Couldn't load subscription status. 
- Fork 32.7k
          [docs][material-ui] Revamp Composition guide
          #43266
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  
    [docs][material-ui] Revamp Composition guide
  
  #43266
              Conversation
| Netlify deploy preview
 Bundle size report | 
| I am not sure who to ask for a review here. | 
| Can I get a review here? | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice
Co-authored-by: Aarón García Hervás <aaron.garcia.hervas@gmail.com> Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
| 
 Sorry for the delay. For next time, if it's related to structure of the docs, please include @samuelsycamore in the review. | 
This PR addresses the feedback provided in #41590 by improving the Composition guide.
Changes by Commit
refto children.<ListItem button />with<ListItemButton>.componentprop accepts any React component, removing an unnecessary discussion on prop forwarding.role="undefined"fromLink(see docs on when it's needed), asListItemButtonwhich rendersButtonBasealready handles therolewhentoprop is provided to it.Previews