Skip to content

[code-infra] Remove a few ts-ignore comments#43265

Merged
mj12albert merged 18 commits into
mui:masterfrom
Janpot:ts-ignore
Apr 17, 2026
Merged

[code-infra] Remove a few ts-ignore comments#43265
mj12albert merged 18 commits into
mui:masterfrom
Janpot:ts-ignore

Conversation

@Janpot
Copy link
Copy Markdown
Member

@Janpot Janpot commented Aug 11, 2024

babysteps towards a healthier code base

  • Removing some obsolete // @ts-ignore comments.
  • Adjust typing to make some other obsolete
  • Install missing @types package
  • Replace some with // @ts-expect-error

@Janpot Janpot added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Aug 11, 2024
@mui-bot
Copy link
Copy Markdown

mui-bot commented Aug 11, 2024

Netlify deploy preview

https://deploy-preview-43265--material-ui.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 779ed0c

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 12, 2024
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 13, 2024
@Janpot Janpot marked this pull request as ready for review August 13, 2024 09:51
@zannager zannager requested a review from mnajdova August 13, 2024 13:45
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 27, 2024
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 2, 2025
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 16, 2025
Resolve conflicts by preferring master for files where the PR's changes
have been superseded (Joy UI removal, Slider useSlider cloning fix,
extractInfoFromType.ts removal, getPropTypesFromFile.ts rewrite).

Scope-trim the docs/next.config.ts webpack Configuration typing
refactor to avoid introducing @types/webpack-bundle-analyzer dep; keep
the ts-ignore removals in the other files.
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 17, 2026
@code-infra-dashboard
Copy link
Copy Markdown

Bundle size

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/private-theming 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Deploy preview

https://deploy-preview-43265--material-ui.netlify.app/


Check out the code infra dashboard for more information about this PR.

@mj12albert mj12albert merged commit 9b741fd into mui:master Apr 17, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants