[Button] Apply default size styles #42502
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
component: button
mnajdova
commented
Jun 3, 2024
| @@ -215,7 +215,6 @@ const ButtonRoot = styled(ButtonBase, { | |||
| { | |||
| props: { | |||
| size: 'small', | |||
| variant: 'text', | |||
There was a problem hiding this comment.
The text variant is default, so in principle this shouldn't change a lot the behavior. It only rely matters when a custom variant is being created.
Netlify deploy previewhttps://deploy-preview-42502--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32427
This PR applies the sizes for the default variant as a base style. This way adding custom variants won't break the size prop.