[docs-infra] Add configurable jsdoc host variable #42472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-42472--material-ui.netlify.app/ Bundle size report |
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Signed-off-by: Anthony Gravell <73857273+tonygravell@users.noreply.github.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Signed-off-by: Anthony Gravell <73857273+tonygravell@users.noreply.github.com>
DiegoAndai
reviewed
Jun 5, 2024
| translationPagesDirectory: 'docs/translations/api-docs-base', | ||
| generateClassName: generateUtilityClass, | ||
| isGlobalClassName: isGlobalState, | ||
| // #major-version-switch |
There was a problem hiding this comment.
@mnajdova is #major-version-switch the correct flag? I don't know if we have another flag for it.
There was a problem hiding this comment.
#default-branch-switch is much more used, honestly first time I see the #major-version-switch :)
There was a problem hiding this comment.
Come from here. I will harmonize it 👍
oliviertassinari
added
type: bug
oliviertassinari
changed the title
mnajdova
changed the title
mnajdova
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
LGTM 👌, thanks for the contribution! I will let @alexfauquette do the last review.
alexfauquette
approved these changes
Jun 7, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Signed-off-by: Anthony Gravell <73857273+tonygravell@users.noreply.github.com> Co-authored-by: Tony Gravell <tonygravell@Tonys-Mac-mini.local> Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Co-authored-by: alexandre <alex.fauquette@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
baseApiUrlAddresses issue:
#42361