[docs-infra] Split feedback channels per product #42413
Conversation
alexfauquette
added
the
scope: docs-infra
Netlify deploy previewhttps://deploy-preview-42413--material-ui.netlify.app/ Bundle size report |
|
|
||
| const BASE_UI_FEEBACKS_CHANNEL_ID = 'C075LJG1LMP'; | ||
| const MATERIAL_UI_FEEBACKS_CHANNEL_ID = 'C0757QYLK7V'; | ||
| // const PIGMENT_CSS_FEEBACKS_CHANNEL_ID = 'C074TBW0JKZ'; |
There was a problem hiding this comment.
@brijeshb42 I assume we don't have pages for now
| const X_GRID_FEEBACKS_CHANNEL_ID = 'C0757R0KW67'; | ||
| const X_CHARTS_FEEBACKS_CHANNEL_ID = 'C0757UBND98'; | ||
| const X_EXPLORE_FEEBACKS_CHANNEL_ID = 'C074TBYQK2T'; | ||
| // const DESIGN_KITS_FEEBACKS_CHANNEL_ID = 'C075ADGN0UU'; |
There was a problem hiding this comment.
@oliviertassinari Do you have a specific page in mind, or is it just an idea for latter for the design kits? Because for now, they don't have pages with feedback input. Or at least I did not find them
There was a problem hiding this comment.
It was an idea for later, but we have https://mui.com/material-ui/design-resources/material-ui-for-figma/
| if (url.includes('/x/react-date-pickers') || url.includes('/x/react-tree-view')) { | ||
| return X_EXPLORE_FEEBACKS_CHANNEL_ID; | ||
| } | ||
| if (url.includes('/x/react-data-grid')) { |
There was a problem hiding this comment.
This doesn't work, e.g. https://mui.com/x/api/data-grid/data-grid/. Is there a way we could rely on productId rather than URLs? For example, once we move the docs to subdomains, this will break.
The team is mostly me bothered by all the data grid feedback I don't care about 😅 |
| | 'x-date-pickers' | ||
| | 'x-charts'; | ||
| | 'x-charts' | ||
| | 'x-tree-view' | ||
| | 'toolpad-studio' | ||
| | 'toolpad-core'; | ||
|
|
There was a problem hiding this comment.
I don't know why it's in master but not in next
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
oliviertassinari
added
the
type: enhancement
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
5 participants
Fix mui/mui-public#168
@mui/docs-infra Tested on
docs-feedback-material-uianddocs-feedback-base-ui. Will need to be merge to test for X channels