Skip to content

[v8][material-ui][createTypography] Button text wrap issue #42171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[v8][material-ui][createTypography] Button text wrap issue #42171

wants to merge 3 commits into from
+1 −1

Conversation

successbyte
Copy link

@successbyte successbyte commented May 9, 2024 •
edited
Loading

Closes #38675

@mui-bot
Copy link

mui-bot commented May 9, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42171--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 55897ad

@aarongarciah aarongarciah added package: material-ui Specific to @mui/material component: button This is the name of the generic UI component, not the React module! component: Typography The React component. labels May 9, 2024
@zannager zannager requested a review from siriwatknp May 9, 2024 12:58
@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented May 21, 2024 •
edited
Loading

@siriwatknp Can you review this?

@successbyte
Copy link
Author

Hello guys can you help what should I do to pass these checks
I want to be a part of MUI Community
thanks to all.

@ZeeshanTamboli
Copy link
Member

@siriwatknp Pending review.

@DiegoAndai
Copy link
Member

Hey @siriwatknp, may I ask you to take a look at this one when you have some time? Thanks in advance 😊

siriwatknp
siriwatknp approved these changes May 7, 2025
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for your contribution! this is a breaking change (causing all buttons's height to change), so it's probably better to wait for v8.

@siriwatknp siriwatknp mentioned this pull request May 7, 2025
Closed
1 task
@siriwatknp siriwatknp added on hold There is a blocker, we need to wait v8.x labels May 7, 2025
@siriwatknp siriwatknp changed the title [material-ui][createTypography] Button text wrap issue [v8][material-ui][createTypography] Button text wrap issue May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: button This is the name of the generic UI component, not the React module! component: Typography The React component. on hold There is a blocker, we need to wait package: material-ui Specific to @mui/material v8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Button] Text wrap issue
6 participants
@successbyte @mui-bot @ZeeshanTamboli @DiegoAndai @siriwatknp @aarongarciah