[material-ui][types] Make slots partial in CreateSlotsAndSlotProptype
#42077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-42077--material-ui.netlify.app/ Bundle size report |
|
Thanks for working on this @lhilgert9! I'm on board with the changes. What do you think, @siriwatknp? Does this make sense to you? |
|
@DiegoAndai @siriwatknp What about this one? |
|
@DiegoAndai @siriwatknp Can you review this? The PR has been open for a while. |
|
@lhilgert9 I'm so sorry for the late reply. The v6 stable release consumed most of my time in the past month. I'm still on board with this change. What do you think about removing |
|
@DiegoAndai Done🚀 |
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DiegoAndai
As already discussed in #41875, here is the PR to make the slots in the CreateSlotsAndSlotProps help type partial to avoid possible errors.