-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][TextField] Fix the Textarea link in the multiline section #41961
Conversation
k-utsumi
commented
Apr 19, 2024
- I have followed (at least) the PR section of the contributing guide.
Signed-off-by: k-utsumi <k-utsumi@users.noreply.github.com>
@samuelsycamore What do you think of this? Can you take a look? |
Signed-off-by: k-utsumi <k-utsumi@users.noreply.github.com>
I can see reasonable arguments on both sides, and I don't have a strong opinion either way. That said, I would err on the side of leaving this as is for now. It's a little annoying to be redirected to a different page like this, but the alternative is that the user would leave the Material UI docs and land in the Base UI docs without any understanding of why. I think it's important for anyone using the Textarea Autosize component in Material UI to know that it will be removed. Alternatively, we could change the link and add a note to the Base UI page explaining why Material UI users are landing there. I'm curious what @danilo-leal thinks about this. |
Seems like a safe change; I think it's okay to do it. Though I'd do a bit more to get to @samuelsycamore's recommendation to give more context:
(And on a more tactical note, I'd point this PR to |
Closing this PR and continuing the work in #44581 |