Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy-ui] Remove unnecessary styles in color inversion footer demo #41419

Merged
merged 1 commit into from
Mar 10, 2024
Merged

[docs][joy-ui] Remove unnecessary styles in color inversion footer demo #41419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[joy-ui][docs] Remove Unnecessary Styles 
1. `--ListItem-gap`: removed the gap for each list item. Since every list item only has one child, the gap isn’t useless.
2. `--ListItemDecorator-size`: got rid of this style because no decorator was used, and it’s not needed.
  • Loading branch information
@cipherlogs
cipherlogs committed Mar 9, 2024
commit 49106a44b0590f87e26ba6b0d948b56fba451fde
4 changes: 2 additions & 2 deletions docs/data/joy/main-features/color-inversion/ColorInversionFooter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export default function ColorInversionFooter() {
size="sm"
orientation="horizontal"
wrap
sx={{ flexGrow: 0, '--ListItem-radius': '8px', '--ListItem-gap': '0px' }}
sx={{ flexGrow: 0, '--ListItem-radius': '8px' }}
>
<ListItem nested sx={{ width: { xs: '50%', md: 140 } }}>
<ListSubheader sx={{ fontWeight: 'xl' }}>Sitemap</ListSubheader>
Expand All @@ -121,7 +121,7 @@ export default function ColorInversionFooter() {
</ListItem>
<ListItem nested sx={{ width: { xs: '50%', md: 180 } }}>
<ListSubheader sx={{ fontWeight: 'xl' }}>Products</ListSubheader>
<List sx={{ '--ListItemDecorator-size': '32px' }}>
<List>
<ListItem>
<ListItemButton>Joy UI</ListItemButton>
</ListItem>
Expand Down
4 changes: 2 additions & 2 deletions docs/data/joy/main-features/color-inversion/ColorInversionFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export default function ColorInversionFooter() {
size="sm"
orientation="horizontal"
wrap
sx={{ flexGrow: 0, '--ListItem-radius': '8px', '--ListItem-gap': '0px' }}
sx={{ flexGrow: 0, '--ListItem-radius': '8px' }}
>
<ListItem nested sx={{ width: { xs: '50%', md: 140 } }}>
<ListSubheader sx={{ fontWeight: 'xl' }}>Sitemap</ListSubheader>
Expand All @@ -126,7 +126,7 @@ export default function ColorInversionFooter() {
</ListItem>
<ListItem nested sx={{ width: { xs: '50%', md: 180 } }}>
<ListSubheader sx={{ fontWeight: 'xl' }}>Products</ListSubheader>
<List sx={{ '--ListItemDecorator-size': '32px' }}>
<List>
<ListItem>
<ListItemButton>Joy UI</ListItemButton>
</ListItem>
Expand Down
Loading