[website] Refine the Material UI homepage demo #40881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
design
Netlify deploy previewhttps://deploy-preview-40881--material-ui.netlify.app/ Bundle size report |
|
Off-topic On this page, there is one thing that has been driving me crazy for a long time. The load animation is a firework 🎇 Screen.Recording.2024-02-01.at.00.55.49.movI would expect 1 state transition, there are 4 on the video. |
zanivan
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
It looks great! While reviewing, I thought about having our custom style demos adopt the same styling as our new template theme. What do you think? (Definitely in a further PR)
|
For sure, that's a great idea! I'll look for tackling it soon in a next one 🤙 |
mostafa-rio
pushed a commit
to mostafa-rio/material-ui
that referenced
this pull request
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly just a fine-tuning of the Material UI homepage demo. On browsing the website on my phone, I noticed this particular demo could be polished a bit. Also, in bento grids' day and age, visitors will hover/try to interact with the demo naturally. Therefore, the "hover over" supporting text stopped feeling that necessary (plus, we were displaying it on mobile, which doesn't really make sense). I also took the opportunity to add random clean-ups in a few components.
Preview: https://deploy-preview-40881--material-ui.netlify.app/