Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Generalize and publish proptypes generator #40757

Draft
wants to merge 6 commits into
base: v5.x
Choose a base branch
from

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Jan 23, 2024

  • Created the new @mui-internal/proptypes-builder package. It was extracted from the existing proptypes generation script and cleaned up to be more self-contained and configurable.
  • Moved TS project related types and functions to @mui-internal/docs-utilities so they can be shared between packages.

This PR is built on top of #40842 and should be merged after it.

@michaldudak michaldudak added the scope: code-infra Specific to the core-infra product label Jan 23, 2024
@mui-bot
Copy link

mui-bot commented Jan 23, 2024

Netlify deploy preview

https://deploy-preview-40757--material-ui.netlify.app/

Bundle size report

Bundle size will be reported once CircleCI build #644182 finishes.

Generated by 🚫 dangerJS against fefcf51

@michaldudak michaldudak force-pushed the make-proptypes-generic branch from 5ff3e77 to c57a0bb Compare January 23, 2024 10:43
@michaldudak michaldudak marked this pull request as ready for review January 24, 2024 07:30
@michaldudak michaldudak requested a review from a team January 24, 2024 07:30
@Janpot
Copy link
Member

Janpot commented Jan 24, 2024

Is there an impact on X?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 24, 2024
@michaldudak
Copy link
Member Author

Yes, I'm working on a PR in X.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 25, 2024
@michaldudak
Copy link
Member Author

X integration PR: mui/mui-x#11801

"strict": true,
"baseUrl": "./",
"paths": {
"react-docgen": ["./react-docgen.d.ts"]
Copy link
Member

@Janpot Janpot Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be missing something, but where is this file?
(also, I'd have expected this to be under "types", that's why I'm asking)

@michaldudak michaldudak changed the title [code-infra] Generalize proptypes generator [code-infra] Generalize and publish proptypes generator Jan 26, 2024
@michaldudak michaldudak force-pushed the make-proptypes-generic branch 2 times, most recently from 244145c to 795ed4e Compare January 26, 2024 13:55
@michaldudak michaldudak marked this pull request as draft January 26, 2024 13:55
@michaldudak michaldudak force-pushed the make-proptypes-generic branch 2 times, most recently from 9a3b2e4 to fb1fbe0 Compare January 26, 2024 14:06
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 29, 2024
@michaldudak
Copy link
Member Author

michaldudak commented Jan 29, 2024

This is getting too big for a single PR. I'm going to split it into smaller ones.

@michaldudak michaldudak force-pushed the make-proptypes-generic branch from fb1fbe0 to 20d13e2 Compare January 29, 2024 13:14
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 29, 2024
@michaldudak michaldudak force-pushed the make-proptypes-generic branch from 20d13e2 to d97563c Compare January 29, 2024 14:42
@michaldudak
Copy link
Member Author

Here are the extracted bits: #40842

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants