-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Generalize and publish proptypes generator #40757
base: v5.x
Are you sure you want to change the base?
Conversation
Netlify deploy previewhttps://deploy-preview-40757--material-ui.netlify.app/ Bundle size reportBundle size will be reported once CircleCI build #644182 finishes. |
5ff3e77
to
c57a0bb
Compare
Is there an impact on X? |
Yes, I'm working on a PR in X. |
X integration PR: mui/mui-x#11801 |
"strict": true, | ||
"baseUrl": "./", | ||
"paths": { | ||
"react-docgen": ["./react-docgen.d.ts"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be missing something, but where is this file?
(also, I'd have expected this to be under "types", that's why I'm asking)
244145c
to
795ed4e
Compare
9a3b2e4
to
fb1fbe0
Compare
This is getting too big for a single PR. I'm going to split it into smaller ones. |
fb1fbe0
to
20d13e2
Compare
20d13e2
to
d97563c
Compare
Here are the extracted bits: #40842 |
@mui-internal/proptypes-builder
package. It was extracted from the existing proptypes generation script and cleaned up to be more self-contained and configurable.@mui-internal/docs-utilities
so they can be shared between packages.This PR is built on top of #40842 and should be merged after it.