-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Revamp the testimonial section in the homepage #40752
[website] Revamp the testimonial section in the homepage #40752
Conversation
Netlify deploy previewhttps://deploy-preview-40752--material-ui.netlify.app/ Bundle size report |
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great! I like how we can see all the testimonials at once now 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heading structure is a bit broken:
Fixing this in #40912.
borderRadius: 1, | ||
overflow: 'clip', | ||
'> :nth-of-type(1)': { borderBottom: `1px solid ${theme.palette.primaryDark[700]}` }, | ||
'> :nth-of-type(2)': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a syntax perspective, I would be more in favor to always be explicit. A bit similar to the native CSS feature https://developer.mozilla.org/en-US/docs/Web/CSS/Nesting_selector (not directly related API though)
'> :nth-of-type(2)': { | |
'& > :nth-of-type(2)': { |
This PR's changes include:
https://deploy-preview-40752--material-ui.netlify.app/