Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[styled-engine-sc][system] Use namespaced theme prop for css functions in styled-engine-sc #40656

Closed
wants to merge 4 commits into from
Closed

[styled-engine-sc][system] Use namespaced theme prop for css functions in styled-engine-sc #40656

wants to merge 4 commits into from

Conversation

delijah
Copy link

@delijah delijah commented Jan 17, 2024 •
edited
Loading

Fixes part 2 of #40140

Codesandbox: https://codesandbox.io/p/devbox/fix-styled-engine-sc-css-theme-object-lpkkcv?file=%2Fsrc%2FApp.tsx%3A11%2C1

This PR could probably be considered as a breaking change.

@delijah delijah marked this pull request as draft January 17, 2024 17:14
@mui-bot
Copy link

mui-bot commented Jan 17, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-40656--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 63b1db7

@delijah delijah changed the title [styled-engine-sc][mui-system] Fix styled engine sc css func theme [styled-engine-sc][system] Fix styled engine sc css func theme Jan 17, 2024
@delijah delijah changed the title [styled-engine-sc][system] Fix styled engine sc css func theme [styled-engine-sc][system] Fix theme prop for css functions in styled-engine-sc Jan 17, 2024
@delijah delijah changed the title [styled-engine-sc][system] Fix theme prop for css functions in styled-engine-sc [styled-engine-sc][system] Use namespaced theme prop for css functions in styled-engine-sc Jan 17, 2024
@delijah delijah marked this pull request as ready for review January 18, 2024 14:44
@delijah delijah mentioned this pull request Jan 18, 2024
Open
2 tasks
@delijah delijah marked this pull request as draft January 18, 2024 15:02
@delijah delijah marked this pull request as ready for review January 18, 2024 18:25
@zannager zannager added the package: styled-engine-sc Specific to styled-components label Jan 19, 2024
@siriwatknp
Copy link
Member

I will wait for #40690 before continuing this PR.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 6, 2024
@siriwatknp
Copy link
Member

@delijah #40690 is merged but I suggest to combine the changes in #40640 and close this one. What do you think?

@delijah
Copy link
Author

delijah commented Feb 7, 2024 •
edited
Loading

@delijah #40690 is merged but I suggest to combine the changes in #40640 and close this one. What do you think?

Actually this PR makes #40640 obsolete. My idea was to merge #40640 first (since it contains no breaking changes and is way simpler than this one) and then later this one.

I guess this one needs some heavy refactoring after merging #40690? :) Should i try to do it, or do you want to do it?

@DND-IT DND-IT closed this by deleting the head repository Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
package: styled-engine-sc Specific to styled-components PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@delijah @mui-bot @siriwatknp @DND-IT @zannager