[material-next][Select] Refactor to use Base UI's hooks #40210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40210--material-ui.netlify.app/ @mui/material-next: parsed: +0.40% , gzip: +0.64% Bundle size reportDetails of bundle changes (Toolpad) |
DiegoAndai
added
the
component: select
DiegoAndai
force-pushed
the
material-select-with-base-ui
branch
2 times, most recently
from
ce9a10a
to
d5546b0
Compare
This was referenced Dec 20, 2023
DiegoAndai
force-pushed
the
material-select-with-base-ui
branch
4 times, most recently
from
fd56820
to
c1f92b4
Compare
github-actions
bot
added
the
PR: out-of-date
DiegoAndai
force-pushed
the
material-select-with-base-ui
branch
from
c1f92b4
to
d1327d7
Compare
github-actions
bot
removed
the
PR: out-of-date
DiegoAndai
commented
Dec 29, 2023
|
|
||
| The menu dependency was removed, and the `MenuProps` prop was removed with it. | ||
|
|
||
| (Section WIP) |
There was a problem hiding this comment.
We will need to create a follow-up issue for this one as it will depend on the changes for the Material You design, which we're not doing right now.
|
Given Base UI's decision to adopt the Composition API and Material UI to be built on top of that API instead of hooks, I'll close this PR. We can use it as a guide for implementing Material UI's Select on top of Base UI's Composition API. This will reduce the friction for Base UI's Composition API refactor. |
oliviertassinari
modified the milestones:
Material UI v7 (draft),
Material UI v8 (draft)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the
SelectInputcomponent based on Base UI'suseSelecthook. This also implies adding theOptioncomponent, which consumes theuseOptionhook.Experiment
https://deploy-preview-40210--material-ui.netlify.app/experiments/material-next/select/
Issues solved with this refactor
Selectcomponent to render additional elements in dropdown #34516Breaking changes
MenuItemreplaced withOption. Users can just copy-pasteOptionwherever they hadMenuItem, as it supports the same API exceptselected, which is ignored whenMenuItemis insideSelectanyways.MenuPropswas removed. We should be able to support most of the functionality either via thePopoverPropsprop (added in this PR) or newSelectprops (not yet added)