-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Add a collapsible list & table views to the API content display #38265
[docs-infra] Add a collapsible list & table views to the API content display #38265
Conversation
Netlify deploy previewhttps://deploy-preview-38265--material-ui.netlify.app/ Bundle size report |
I chatted a bit with @alexfauquette, it could be really great to run an A/B on this. We could have 3 implementations:
and see which one the developers pick the most as their default. Personally, as a developer, I would definitely put 2. last, too much effort to click, scrolling is easier. I would have to try 1 and 3 long enough to really know for sure, maybe a slight preference for 3. |
@oliviertassinari I recently wrote a doc about the API content display and the A/B test idea could maybe be discussed more in-depth there! I personally don't see a lot of value in testing something close to Blueprint but happy to further discuss on Notion considering what Alex & I discussed that's documented there! 😃 |
I like the UX on this one, it solves the main problem with the current design (which mixes secondary with primary information on the same vertical space and breaks quick skimming). Overall I think the card design is good, I'd bet we just need to keep the primary information quickly scannable. |
To simplify experimentation, I added a page with data grid premium API docs such that we can see in live the impact on big API page https://deploy-preview-38265--material-ui.netlify.app/experiments/docs/data-grid-premium/ ![]() Based on the comments "I want to easily scan the props or description", I moved to a table layout with props/description column I allow a first column of up to 200px. If the props overflow, their name is cut in two (mainly for data grid unstable props) Props now have a check box on top of it to enable/disable collapsed rows Todo
|
@alexfauquette The plan sounds great. Let's 🔬, see how developers behave. I think this is a viable implementation to test 3. in #38265 (comment). I have added a screenshot to illustrate it. I would only raise that the prop description font is wrong, it uses |
🎉🎉 Celebration time 🎉🎉 I just need to review my own code to make sure the data are correctly sent to Google Analytics, such that we can do something with them. Should be ready for the next release 🚀 |
…ial-ui into test-expendable-docs
…display (mui#38265) Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
…display (mui#38265) Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
…display (mui#38265) Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Preview