Skip to content

[Autocomplete] Add Mui-expanded class #33312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 28, 2023
Merged

[Autocomplete] Add Mui-expanded class #33312

merged 12 commits into from
Feb 28, 2023

Conversation

makeeno
Copy link
Contributor

@makeeno makeeno commented Jun 27, 2022 •
edited by ZeeshanTamboli
Loading

Closes #33258

@mui-bot
Copy link

mui-bot commented Jun 27, 2022 •
edited
Loading

Netlify deploy preview

https://deploy-preview-33312--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against e211eff

@makeeno makeeno changed the title ✨ add expanded class for Autocomplete [Autocomplete] add expanded class for Autocomplete Jun 27, 2022
@makeeno makeeno changed the title [Autocomplete] add expanded class for Autocomplete [Autocomplete] add expanded class Jun 27, 2022
@makeeno makeeno changed the title [Autocomplete] add expanded class [Autocomplete] add Mui-expanded class Jun 27, 2022
@makeeno
Copy link
Contributor Author

makeeno commented Jun 27, 2022

The expanded attribute in autocomplete.json doesn't look like the other ones. Not sure how to generate it properly.

@makeeno makeeno marked this pull request as ready for review June 27, 2022 16:30
michaldudak
michaldudak reviewed Jul 1, 2022
View reviewed changes
@michaldudak michaldudak added type: new feature Expand the scope of the product to solve a new problem. scope: autocomplete Changes related to the autocomplete. This includes ComboBox. package: material labels Jul 1, 2022
@makeeno @michaldudak
Update packages/mui-material/src/Autocomplete/autocompleteClasses.ts
abdfe7b 
Co-authored-by: Michał Dudak <michal.dudak@gmail.com>
@michaldudak
Copy link
Member

The changes look good. You need to run yarn docs:api to generate documentation based on JSDoc comments.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 19, 2022
mnajdova
mnajdova reviewed Feb 23, 2023
View reviewed changes
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Feb 23, 2023
mnajdova
mnajdova approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a few commits to update to the latest master and fix a regression. Looks good to me now! cc @michaldudak for a final review

ZeeshanTamboli
ZeeshanTamboli reviewed Feb 28, 2023
View reviewed changes
@ZeeshanTamboli ZeeshanTamboli changed the title [Autocomplete] add Mui-expanded class [Autocomplete] Add Mui-expanded class Feb 28, 2023
ZeeshanTamboli
ZeeshanTamboli approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the logic inside the useAutocomplete hook and added tests. Looks good to me. @Osman-Sodefa Thanks for your contribution!

@ZeeshanTamboli ZeeshanTamboli merged commit 3ca7a1b into mui:master Feb 28, 2023
@sai6855 sai6855 mentioned this pull request Mar 11, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak left review comments

@mnajdova mnajdova mnajdova approved these changes

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
scope: autocomplete Changes related to the autocomplete. This includes ComboBox. type: new feature Expand the scope of the product to solve a new problem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Autocomplete] Add additional class names to Autocomplete if it is expanded
5 participants
@makeeno @mui-bot @michaldudak @mnajdova @ZeeshanTamboli