[ButtonBase] Ensure that onClick propagates when non-native button is clicked

[kmurgic]

• I have followed (at least) the PR section of the contributing guide.

This should solve #30144. I don't believe there are any unintended negative consequences from programmatically clicking the button, but someone please double check me on that. Although, one concern could be this being a breaking change for someone who is checking to see if the button onClick function was triggered by a keyboard event? I'm open to suggestions for different fixes to this bug if we need to make sure we are still passing the keyboard event to the onClick handler.

[mui-pr-bot]

Details of bundle changes

Generated by 🚫 dangerJS against 6268ece

[kmurgic]

Just noticed that I have some failing tests, fixing now.

[kmurgic]

Okay, fixed the tests. If we need to pass the original keyboard event to the onClick handler then there's still a bit more work to do, but waiting to look into that until I get some feedback!

[michaldudak]

Hi @kmurgic! Thanks for your PR. The change you introduced makes a lot of sense as it improves consistency between using the native button and a custom element.
However, as you noticed, this is a breaking change. Not only we're changing the type of the fired event, but also the defaultPrevented is different. We could include this change in the next major version, but I don't think it would be safe to do so now.

[kmurgic]

I spent a little time digging and I couldn't find another good way to trigger the event propagation. The best I could do was to fire the event on the parent element, but then the event has the wrong target element. I'm throwing in the towel on doing this without breaking changes, but someone else may want to try. If we can't fix this bug then maybe MUI should document somewhere the known issue with keyboard accessibility when using an onClick on the Menu component.

[michaldudak]

Let's keep this PR open. We'll get back to it once we're closer to v6.

[kmurgic]

@michaldudak should we close this now that v6 is released?

[michaldudak]

@DiegoAndai - do you know what's the status of this?

[mnajdova]

I think we can include this fix in v7. I am changing the branch where we want to fix this (to master). cc @DiegoAndai