[Tab] iconPosition prop added in Tab

[deepanshu2506]

• I have followed (at least) the PR section of the contributing guide.

close #11653

added a prop to tab component that specifies the icon position as "top" , "left", "bottom" or "right"

Default position is top.

[mui-pr-bot]

Details of bundle changes

@material-ui/core: parsed: +0.09% , gzip: +0.07%
@material-ui/lab: parsed: +0.11% , gzip: +0.08%

Generated by 🚫 dangerJS against b2a362a

[deepanshu2506]

@oliviertassinari please review

[siriwatknp]

@deepanshu2506 Thanks for the PR. However, I am hesitant about it because in v5 you can do it via sx prop which I think is more flexible. https://codesandbox.io/s/iconlabeltabs-material-demo-forked-degj9?file=/demo.js

By adding API for the sake of styling which does not include in the guideline, it increases the maintenance afford in the future.

cc @mui-org/core for more opinions.

[hbjORbj]

@deepanshu2506 In your current implementation, iconPosition prop is meaningful if only if it is used together with label prop. While I understand that it's not a common use case to place icon at a certain position without label, I think that the prop name can be misleading.

[deepanshu2506]

So should this PR be carried forward or not?

[siriwatknp]

So should this PR be carried forward or not?

Let's wait for comments from other people for a few days.

[mnajdova]

In my opinion, the API is pretty common so I would say it's a nice addition. Both positions of the icons (start and top) can be found on the Material Design guidlines.

[siriwatknp]

To move forward, I think this PR needs

• a demo playground (let's show all positions at once to leverage visual regression test)

[siriwatknp]

👍 This is a great improvement!

[mnajdova]

@deepanshu2506 it's a great first pull request on MUI 👌 Thank you for working on it!