Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system] Fix missing typings for createSpacing #28361

Merged
merged 2 commits into from
Sep 15, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 15, 2021

Closes #28359 (though I do not fully understand why. I still suspect #28359 is just a race condition.)

@eps1lon eps1lon added bug 🐛 Something doesn't work typescript package: system Specific to @mui/system labels Sep 15, 2021
@@ -10,6 +10,6 @@
"outDir": "build",
"rootDir": "./src"
},
"include": ["src/**/*.ts"],
"include": ["src/**/*.ts*"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by change for future compat

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 15, 2021

No bundle size changes

Generated by 🚫 dangerJS against 03f32e4

@eps1lon eps1lon marked this pull request as ready for review September 15, 2021 14:10
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix the issue. Thanks.

@eps1lon eps1lon merged commit d853515 into mui:master Sep 15, 2021
@eps1lon eps1lon deleted the core/fix/repeated-builds branch September 15, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: system Specific to @mui/system typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Running release:build twice causes errors
3 participants