[Button] Fix forward classes to ButtonBase#25072
Merged
Merged
Conversation
praveenkumar-kalidass
force-pushed
the
button-classes
branch
from
16634f7 to
631716f
Compare
oliviertassinari
added
type: bug
oliviertassinari
approved these changes
Feb 23, 2021
Member
oliviertassinari
left a comment
oliviertassinari
left a comment
There was a problem hiding this comment.
In practice, it means that developers can provide classes that aren't supposed to be accessible, but they are not documented, so I think that we are good.
Member
|
@praveenkumar-kalidass Thanks |
Member
|
Appreciate the extra test case |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes classes not getting added to button element.
Why is it needed?
Forwards classes from Button component prop to ButtonBase component.
Related issue(s)/PR(s)
Closes #25011