[Autocomplete] Fix useAutocomplete groupedOptions type

[ZachCMP]

• I have followed (at least) the PR section of the contributing guide.

Question about this:

I had to update the demos to fix type errors caused by the type definition change. The current demos aren't explicit about the fact that groupedOptions changes shape when groupBy is provided; And their behavior will actually break without explanation if you do provide groupBy to useAutocomplete (Demo). With the type definition change, you do get type errors now if you don't handle the union type on groupedOptions, which is good, but I think it would be of benefit to add a bit more explanation of that behavior to the demos, as it seems a bit unexpected to me. I'm happy to do that, I'm just wondering what form you think would be appropriate. Would just a comment do? Would you want an example of how to actually handle the different types? Or something else? What do you think?

Fixes #23846

[mui-pr-bot]

No bundle size changes

Generated by 🚫 dangerJS against 57b5065

[oliviertassinari]

How about this comment?

[ZachCMP]

@oliviertassinari Yeah, that would work. Can we be explicit that "if the grouping feature is enabled" means that the groupBy prop is defined? Otherwise I'm not sure it's clear exactly when "the grouping feature is enabled". So something like:

The options to render. It's either `T[]` or `AutocompleteGroupedOption<T>[]` if the groupBy prop is provided.

[oliviertassinari]

@ZachCMP Sure, it sounds good.

[ZachCMP]

@oliviertassinari Comment updated. I'm happy with it now. Let me know if there's anything else you'd like me to add to this PR

[oliviertassinari]

@ZachCMP Thanks for the polish

[HJain13]

Also came across this problem today. waiting for the new build with this merged in 🙏

[oliviertassinari]

@HJain13 We will likely release this weekend. In the meantime, you could potentially use https://github.com/mui-org/material-ui/blob/next/CONTRIBUTING.md#how-can-i-use-a-change-that-wasnt-released-yet.

[jackHedaya]

Is this included in the most recent version? I'm experiencing this issue on 4.0.0-alpha.57

[oliviertassinari]

@jackHedaya The most recent version is v5.0.0-alpha.21.

[spencermehta]

Shouldn't the type here actually be conditional upon the type of the groupBy prop? If it is not provided the type should be T[] and if it is provided it should be Array<AutocompleteGroupedOption<T>>. With the current implementation I'm forced to handle the case that the options are of type T[] even if I've provided the groupBy prop.