Skip to content

Conversation

digitalextremist
Copy link

Adds <Popover/> import code to component documentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coud you put this in two lines?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I just checked with another component.
Could you fix the travis task ? I will merge then. Thanks.

IMHO, we should have a component to render this. I will work on it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is posting a linter issue from an unrelated area ( events.js which doesn't even seem to be part of this repository... likely npm/gulp related, using bleeding edge or old versions )

Agreed, the documentation does need some heavy duplication removal, and updating to be current with new React event binding behaviors... because all the documentation example cost posts React warnings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the following issue from travis:
ESLintError: Trailing spaces not allowed.

the documentation does need some heavy duplication removal

I can't agree more

new React event binding behaviors... because all the documentation example cost posts React warnings.

What do you mean?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the whitespaces on the empty lines, but it's still complaining; the events.js file it's talking about was not something I touched.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing space is here.

@oliviertassinari
Copy link
Member

Sorry, but the build is green for the master branch. It fail because of your changes.
Could you squash down the commit once it's fixed?
Thanks, I will merge then.

@oliviertassinari
Copy link
Member

@digitalextremist We are almost there. Now it's Paper that is undefined ^^.

@oliviertassinari
Copy link
Member

You know what. I will try to start working, this week, on improving the documentation with a standarized component.
My future PR will try to solve this.

@digitalextremist
Copy link
Author

@oliviertassinari awesome. Added missing Paper import. I am very impressed with this framework and hoping to help more in the future. Thanks for your improvements/work.

@oliviertassinari
Copy link
Member

docs/src/app/components/pages/components/popover.jsx
  91:12  error  'CodeBlock' is not defined  react/jsx-no-undef

@digitalextremist We are glad to hear it.
I would suggest you to install the project locally, this would be more efficient.
Then, you can use npm run lint to run the linting task.

@digitalextremist
Copy link
Author

I will. I've not done much contribution in the world of JavaScript, but am very active in Ruby even including maintaining very significant libraries -- there I do the equivalent, so I'll get my act together.

@oliviertassinari
Copy link
Member

We don't have much maintainer. If you want to be involved in this project, you are welcomed!
Regarding the who we are working, noting is settled, I like they model http://eslint.org/docs/developer-guide/governance.

@digitalextremist
Copy link
Author

So is this library's growth determined by a business' needs, and you work for/with that company?

Thanks for the link.

@oliviertassinari
Copy link
Member

Callemall is rewriting their frontend with it.
For my part, I'm still a student, but I'm using it for a side project (http://play.google.com/store/apps/details?id=com.split.app).
We would have to add a showcase section at some point (like https://facebook.github.io/react-native/showcase.html)

@digitalextremist
Copy link
Author

Oh wow. Right on. I personally am using it heavily, very heavily, in an Electron application. I usually avoid UI oriented work like the plague, but with this MUI library available, Electron has come to feel comfortable to write for. Thanks for the LinkedIn connection.

@oliviertassinari
Copy link
Member

@digitalextremist Here is the PR to improve the way the doc is done #2382.
This is a proof of concept for the AppBar component.
I plan to convert every component doc following the same patern. Hence, your PR is no longer relevent. If you want to help, that's welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants