-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
Include 'import' code block for Popovers, per convention. #2325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coud you put this in two lines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was weird too, but I followed the context:
- https://github.com/callemall/material-ui/blob/master/docs/src/app/components/pages/components/avatars.jsx#L78
- https://github.com/callemall/material-ui/blob/master/docs/src/app/components/pages/components/snackbar.jsx#L111
- https://github.com/callemall/material-ui/blob/master/docs/src/app/components/pages/components/dialog.jsx#L197
- Etc...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I just checked with another component.
Could you fix the travis task ? I will merge then. Thanks.
IMHO, we should have a component to render this. I will work on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is posting a linter issue from an unrelated area ( events.js
which doesn't even seem to be part of this repository... likely npm/gulp related, using bleeding edge or old versions )
Agreed, the documentation does need some heavy duplication removal, and updating to be current with new React
event binding behaviors... because all the documentation example cost posts React
warnings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the following issue from travis:
ESLintError: Trailing spaces not allowed.
the documentation does need some heavy duplication removal
I can't agree more
new React event binding behaviors... because all the documentation example cost posts React warnings.
What do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the whitespaces on the empty lines, but it's still complaining; the events.js
file it's talking about was not something I touched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trailing space is here.
Sorry, but the build is green for the master branch. It fail because of your changes. |
@digitalextremist We are almost there. Now it's |
You know what. I will try to start working, this week, on improving the documentation with a standarized component. |
@oliviertassinari awesome. Added missing |
@digitalextremist We are glad to hear it. |
I will. I've not done much contribution in the world of JavaScript, but am very active in Ruby even including maintaining very significant libraries -- there I do the equivalent, so I'll get my act together. |
We don't have much maintainer. If you want to be involved in this project, you are welcomed! |
So is this library's growth determined by a business' needs, and you work for/with that company? Thanks for the link. |
Callemall is rewriting their frontend with it. |
Oh wow. Right on. I personally am using it heavily, very heavily, in an Electron application. I usually avoid UI oriented work like the plague, but with this MUI library available, Electron has come to feel comfortable to write for. Thanks for the LinkedIn connection. |
@digitalextremist Here is the PR to improve the way the doc is done #2382. |
Adds
<Popover/>
import code to component documentation.