Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[icons] Label them as vendored for GitHub #22397

Merged
merged 2 commits into from
Aug 30, 2020
Merged

[icons] Label them as vendored for GitHub #22397

merged 2 commits into from
Aug 30, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 29, 2020 •
edited
Loading

An alternative to #22188. After this, we should be in much better shape, the stats and breakdown seem to match, more or less reality:

$ github-linguist
75.27%  JavaScript
24.71%  TypeScript
0.02%   HTML

I will be done with this problem.

@oliviertassinari oliviertassinari added package: icons Specific to @mui/icons core Infrastructure work going on behind the scenes labels Aug 29, 2020
@oliviertassinari oliviertassinari mentioned this pull request Aug 29, 2020
Closed
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 29, 2020 •
edited
Loading

No bundle size changes comparing a43ac9f...0e76c41

Generated by 🚫 dangerJS against 0e76c41

mbrookes
mbrookes reviewed Aug 29, 2020
View reviewed changes
.gitattributes Outdated Show resolved Hide resolved
@oliviertassinari @mbrookes
Update .gitattributes
0e76c41 
Co-authored-by: Matt <github@nospam.33m.co>
eps1lon
eps1lon approved these changes Aug 30, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense.

@oliviertassinari oliviertassinari merged commit 4e57752 into mui:next Aug 30, 2020
@oliviertassinari oliviertassinari deleted the icons-vendored branch August 30, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes left review comments

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes package: icons Specific to @mui/icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliviertassinari @mui-pr-bot @mbrookes @eps1lon