-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Restore nextjs cache for size snapshot #20155
Conversation
Details of bundle changes.Comparing: 701e3ad...d12c242 Details of page changes
|
verifies if the cache is properly restored
@@ -5,7 +5,8 @@ | |||
"author": "Material-UI Team", | |||
"license": "MIT", | |||
"scripts": { | |||
"build": "rimraf .next && cross-env NODE_ENV=production next build", | |||
"build": "cross-env NODE_ENV=production next build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaning before building was introduce in #13987 by @oliviertassinari. It seems like it was used for debugging which is why I put it in a dedicated task. Since nextjs actually recommends using build caches we should follow this by default.
Should we look into caching for Netlify? |
Sure but they don't support this with built-in methods so I didn't bother. |
Let's hope they will in the future :) |
Fixes
Warning: No build cache found.
for the runs in azure pipelines using pipeline caching.Edit: Looks like 2-3min reduction which is pretty noticeable.