Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Speed-up typechecking #16413

Merged
merged 5 commits into from
Jun 29, 2019
Merged

[core] Speed-up typechecking #16413

merged 5 commits into from
Jun 29, 2019

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jun 28, 2019 •
edited
Loading

  • Run the typescript command in parallel
  • Added the docs to the workspace
  • Upgraded dtslint and lerna (gave a small boost locally, could be noise)

Local:

Before
  78.61s.
With parallel flag
  67.93s.
Docs in workspace
  45.16s.

CI:

Before
  65s.
After
  34s.

@merceyz merceyz changed the title [build] Run typechecks in parallel [build] Speedup typechecking Jun 28, 2019
eps1lon
eps1lon reviewed Jun 28, 2019
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is put to work today! 😄

docs/package.json Outdated Show resolved Hide resolved
@eps1lon eps1lon changed the title [build] Speedup typechecking [core] Speed-up typechecking Jun 28, 2019
@eps1lon eps1lon added the core label Jun 28, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 28, 2019 •
edited
Loading

No bundle size changes comparing b31810d...22ff165

Generated by 🚫 dangerJS against 22ff165

oliviertassinari
oliviertassinari approved these changes Jun 28, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we win at least 30s :)

@eps1lon eps1lon merged commit ffb125d into mui:master Jun 29, 2019
@merceyz merceyz deleted the typecheck branch June 29, 2019 11:58
@merceyz merceyz mentioned this pull request Jul 15, 2019
Merged
1 task
@zannager zannager added the core Infrastructure work going on behind the scenes label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@merceyz @mui-pr-bot @oliviertassinari @eps1lon @zannager