Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] Remove deprecated fullWidth and scrollable props #15670

Merged
merged 3 commits into from
May 20, 2019

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented May 12, 2019

For people using <Tabs fullWidth scrollable /> in v3, the solution is the following in v4:

const StyledTab = withStyles({
  root: {
    flex: 1,
  },
})(Tab);

@mui-pr-bot
Copy link

mui-pr-bot commented May 12, 2019

Details of bundle changes.

Comparing: 6b73158...6181d7d

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.04% -0.07% 315,279 315,149 86,429 86,370
@material-ui/core/Paper 0.00% 0.00% 67,869 67,869 20,159 20,159
@material-ui/core/Paper.esm 0.00% 0.00% 61,152 61,152 18,952 18,952
@material-ui/core/Popper 0.00% 0.00% 28,740 28,740 10,351 10,351
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,382 2,382
@material-ui/core/TrapFocus 0.00% 0.00% 3,744 3,744 1,581 1,581
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,960 15,960 5,782 5,782
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 975 975
@material-ui/lab 0.00% 0.00% 138,336 138,336 42,572 42,572
@material-ui/styles 0.00% 0.00% 51,353 51,353 15,175 15,175
@material-ui/system 0.00% 0.00% 14,458 14,458 4,178 4,178
Button 0.00% 0.00% 84,061 84,061 25,579 25,579
Modal 0.00% 0.00% 20,344 20,344 6,685 6,685
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 47,836 47,836 10,920 10,920
docs.main 0.00% 0.00% 654,121 654,121 205,688 205,688
packages/material-ui/build/umd/material-ui.production.min.js -0.04% -0.06% 294,254 294,124 83,882 83,829

Generated by 🚫 dangerJS against 6181d7d

@mbrookes mbrookes added the component: tabs This is the name of the generic UI component, not the React module! label May 12, 2019
@eps1lon
Copy link
Member

eps1lon commented May 13, 2019

How does this fit in with #15324? If this was actually useful behavior that can't be replicated with the current API we should probably revert the deprecation entirely?

@mbrookes
Copy link
Member Author

AFAICT, only a couple of styles need to be applied to get the behaviour equivalent to both fixed and scrollable being set at the same time. However I can see the merit in consolidating the API changes to one change in v5, rather than one now, and another one later.

@oliviertassinari oliviertassinari added this to the v4 milestone May 19, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I do think that it's going in the right direction: #15324 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants