Skip to content

[material-ui][Menu] Update icons to behave consistently in light & dark mode #35589

Open
@gerdadesign

Description

@gerdadesign

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example:
Current icon menu: https://mui.com/material-ui/react-menu/#icon-menu in dark mode

Current behavior 😯

Light mode:
Active + unfocused icons are at 54% opacity
Active + focused icons do not change

Dark mode:
Active + unfocused icons are at 100% opacity
Active + focused icons do not change

Expected behavior 🤔

Material Design 2 guidelines for light and dark mode indicated that active + unfocused in dark mode should be at 70% opacity.
Light mode with icons Active + Focused state at 87% #000000; Active + Unfocused state at 54% #000000; Inactive state at 38% #000000

Dark mode with icons Active + Focused state at 100% #FFFFFF; Active + Unfocused state at 70% #FFFFFF; Inactive state at 50% #FFFFFF

Noting that Material Design 3 handles this differently and does not change the icon color upon focus. They opt for outlined vs filled icons in many examples.

Context 🔦

#6619 comment

Your environment 🌎

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug 🐛Something doesn't workcomponent: menuThis is the name of the generic UI component, not the React module!designThis is about UI or UX design, please involve a designerpackage: material-uiSpecific to @mui/material

    Projects

    Status

    No status

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions